[badge]: Badge decoration for active debug sessions #8342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anasshahidd21
force-pushed
the
debugSessionBadge
branch
from
435f29e
to
d9e5a09
Compare
Anasshahidd21
commented
Aug 10, 2020
Anasshahidd21
force-pushed
the
debugSessionBadge
branch
3 times, most recently
from
7960661
to
8847075
Compare
vince-fugnitto
added
badge
akosyakov
reviewed
Aug 11, 2020
Fixes: eclipse-theia#8303 Decorates the debug tab-bar with active debug sessions. Co-authored-by: Kaiyue Pan <kaiyue.pan@ericsson.com> Co-authored-by: Anton Kosyakov <anton.kosyakov@typefox.io> Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
akosyakov
force-pushed
the
debugSessionBadge
branch
from
8847075
to
7638a9e
Compare
|
I've rebased a commit and resolved a cycle generally in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8303
Decorates the debug tab-bar with active debug sessions.
How to test
.specfile from Theia, run the configRun Mocha Testand check to see if the badge for debug reflects it1active sessionReview checklist
Reminder for reviewers