Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-8416: Fixed the menu widget layout. #8419

Merged
merged 1 commit into from
Aug 24, 2020
Merged

GH-8416: Fixed the menu widget layout. #8419

merged 1 commit into from
Aug 24, 2020

Conversation

kittaakos
Copy link
Contributor

Do not break line on spaces.

Closes #8416

Signed-off-by: Akos Kitta kittaakos@typefox.io

What it does

This PR fixes the menu widget layout; it does not break lines on non-breaking whitespace.

How to test

Check the Sample Menu with the browser example, make the horizontal space small enough so you cannot see the last items (Debug, Terminal, and Help) from the main menu bar.

screencast 2020-08-24 09-37-03

Review checklist

Reminder for reviewers

Do not break line on spaces.

Closes #8416

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@akosyakov akosyakov added the shell issues related to the core shell label Aug 24, 2020
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried, it works

@kittaakos kittaakos merged commit 4390a7d into master Aug 24, 2020
@kittaakos kittaakos deleted the GH-8416 branch August 24, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shell issues related to the core shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[menu] Broken menu widget layout
2 participants