Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: Change output-widget file extension #8499

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

DucNgn
Copy link
Contributor

@DucNgn DucNgn commented Sep 11, 2020

Signed-off-by: Duc Nguyen duc.a.nguyen@ericsson.com

What it does

Fixes: #8363
Rename output-widget.tsx to output-widget.ts since there is no need for React code in the file anymore

How to test

  • Check source code file: theia/packages/output/src/browser/output-widget.ts

Review checklist

Reminder for reviewers

Rename `output-widget.tsx` to `output-widget.ts` since there is no need for React code in the file anymore

Signed-off-by: Duc Nguyen <duc.a.nguyen@ericsson.com>
@DucNgn DucNgn changed the title output: Change output-widget extension output: Change output-widget file extension Sep 11, 2020
@vince-fugnitto vince-fugnitto added output issues related to the output quality issues related to code and application quality labels Sep 11, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, and the CI successfully passed.
Thank you for your first contribution 👍

@vince-fugnitto vince-fugnitto merged commit f99c419 into eclipse-theia:master Sep 14, 2020
@DucNgn DucNgn deleted the duc/renameOutputWidget branch September 15, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
output issues related to the output quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[output][quality] Rename the output-widget.tsx module to output-widget.ts
2 participants