Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builtin js-debug and upgrade builtin node debug extensions #8544

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

amiramw
Copy link
Member

@amiramw amiramw commented Sep 22, 2020

This enables debugging npm scripts

Signed-off-by: Amiram Wingarten amiram.wingarten@sap.com

What it does

Fixes: #8500

Add new builtin extension: https://open-vsx.org/api/ms-vscode/js-debug/1.49.8/file/ms-vscode.js-debug-1.49.8.vsix
Upgrade vscode-builtin-node-debug and vscode-builtin-node-debug2

How to test

Debug works as opposed to before this PR.

Review checklist

Reminder for reviewers

This enables debugging npm scripts

Signed-off-by: Amiram Wingarten <amiram.wingarten@sap.com>
@vince-fugnitto vince-fugnitto added builtins Issues related to VS Code builtin extensions debug issues that related to debug functionality labels Sep 22, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well for me 👍
I verified with the provided use-case and could not identify any regressions.

@amiramw amiramw merged commit c321d30 into master Sep 23, 2020
@amiramw amiramw deleted the npm-scripts branch September 23, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions debug issues that related to debug functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Npm script debug not working
2 participants