core: Command Save All only formats the file if it is dirty
#8554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DucNgn
changed the title
Save All only formats the file if it is dirtySave All only formats the file if it is dirty
DucNgn
force-pushed
the
dn/SaveAllNotFormatOnNonDirtyFile
branch
from
e2dad66 to
a95f620
Compare
DucNgn
changed the title
Save All only formats the file if it is dirtySave All only formats the file if it is dirty
1 task
DucNgn
force-pushed
the
dn/SaveAllNotFormatOnNonDirtyFile
branch
2 times, most recently
from
3b46e6f to
466128f
Compare
|
@vince-fugnitto Thanks for the feedbacks. I've updated this PR according to your review. |
DucNgn
force-pushed
the
dn/SaveAllNotFormatOnNonDirtyFile
branch
2 times, most recently
from
934b4ef to
060bd77
Compare
vince-fugnitto
force-pushed
the
dn/SaveAllNotFormatOnNonDirtyFile
branch
from
060bd77 to
9bfbeb6
Compare
DucNgn
force-pushed
the
dn/SaveAllNotFormatOnNonDirtyFile
branch
from
9bfbeb6 to
652ff57
Compare
vince-fugnitto
requested review from
paul-marechal
and removed request for
benoitf and
evidolob
DucNgn
force-pushed
the
dn/SaveAllNotFormatOnNonDirtyFile
branch
4 times, most recently
from
9822692 to
39a4731
Compare
DucNgn
force-pushed
the
dn/SaveAllNotFormatOnNonDirtyFile
branch
from
39a4731 to
d70e2d4
Compare
DucNgn
force-pushed
the
dn/SaveAllNotFormatOnNonDirtyFile
branch
2 times, most recently
from
0c33905 to
1bc9fca
Compare
+ Refactor `SaveOptions` + Command `Save All` only formats the file if it is dirty Signed-off-by: Duc Nguyen <duc.a.nguyen@ericsson.com>
DucNgn
force-pushed
the
dn/SaveAllNotFormatOnNonDirtyFile
branch
from
1bc9fca to
52ad2f0
Compare
vince-fugnitto
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
The changes work well for me 👍
| Use Case | Result |
|---|---|
Save |
saves and formats the given document |
Save (preference off) |
saves but does not format the given document |
Save All (with dirty) |
saves the dirty documents and formats them |
Save All (without dirty) |
does not format the documents |
Save without Formattting |
saves the document without formatting |
|
I'll merge tomorrow if there are no objections 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #8548
Save Allnow formats all open editors #8551 and [core][monaco] ImplementSave without Formattingcommand #8543Save Allnow only formats the file if it is dirtyHow to test
formatOnSaveSave Allfrom command palette or by using shortcutReview checklist
Reminder for reviewers
Signed-off-by: Duc Nguyen duc.a.nguyen@ericsson.com