Made it easier to customize view container part. #8619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Template method for the part creation. - Removed the deprecated API use. - Fixed indentation in CSS. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
vince-fugnitto
added
the
extensibility
vince-fugnitto
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
The changes look good to me 👍
It allows downstream extenders the possibility to customize the creation of the view container part without having to rewrite the entire addWidget method.
I also verified the functionality by confirming the view containers (such as npm scripts) still worked correctly.
|
Thank you for the review, @vince-fugnitto 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akos Kitta kittaakos@typefox.io
What it does
See commit description 👆
How to test
Review checklist
Reminder for reviewers