Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8428-stop-hosted-instance #8674

Merged

Conversation

danarad05
Copy link
Contributor

@danarad05 danarad05 commented Oct 28, 2020

Signed-off-by: Dan Arad dan.arad@sap.com

What it does

Fixes #8428
Fixes #5692

How to test

  1. Start Hosted Plugin debug instance
  2. Click on "Stop instance" - instance should be killed and starting a new instance again should succeed.

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added bug bugs found in the application plug-in system issues related to the plug-in system labels Oct 28, 2020
@kittaakos
Copy link
Contributor

Thanks for your contribution. I will take a look next week. @danarad05, if you're not receiving feedback from me on the PR, name me. Thanks!

Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared with master on Windows and it fixes the mentioned issue. The code looks good but I have a small remark/question.

packages/plugin-ext/src/hosted/node/hosted-plugin.ts Outdated Show resolved Hide resolved
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Please squash your commits before merging.

Signed-off-by: Dan Arad <dan.arad@sap.com>
@danarad05
Copy link
Contributor Author

danarad05 commented Nov 15, 2020

LGTM, thanks! Please squash your commits before merging.

@marechal-p
Done. Thanks

@paul-marechal paul-marechal merged commit cd85908 into eclipse-theia:master Nov 15, 2020
@danarad05 danarad05 deleted the 8428-stop-hosted-instance branch November 19, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application plug-in system issues related to the plug-in system
Projects
None yet
4 participants