Apply CommentThread vscode Plugin API

[vinokurig]

What it does

Apply CommentThread vscode Plugin API

related CQ: http://dev.eclipse.org/ipzilla/show_bug.cgi?id=22902

fixes #8492

How to test

1. Remove "@theia/git": "^1.8.0" from examples/browser/package.json file.
2. Download vscode-git-1.49.3 and copy it to the plugins folder.
3. Download vscode GitHub Pull request plugin and copy it to the plugins folder.
4. Apply GitHub authentication provider:

• Git clone the github authentication plugin to the plugins folder.
• Paste your GitHub token to the plugin here.
• Compile the plugin. Note that errors might appear in the compilation log but it doesn't prevent the plugin from working properly.

5. Start Theia and open a project cloned from GitHub with a Pull-Request e.g. https://github.com/vinokurig/environment-variable.git
6. Sign in the GitHub Pull-Requests Plugin:
   
7. Open a pull-request in the plugin:
   
8. Open a changed file with comments:
   

See: Pull-Request comments are available in the diff. You can add some new comments by clicking the white line and delete and edit existing comments.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[azatsarynnyy]

When I'm trying to add a comment to the PR, it's failed with the error notification.
And another input area has appeared below after clicking Save button.

[azatsarynnyy]

After clicking Cancel, it shows the comment (x2) but they're not on the GitHub vinokurig/environment-variable#12

[azatsarynnyy]

I've tried Delete Comment button, but it does nothing.
Maybe some additional steps are required to configure the feature on my side?

[vinokurig]

@azatsarynnyy

When I'm trying to add a comment to the PR, it's failed with the error notification.
And another input area has appeared below after clicking Save button.

I couldn't reproduce this issue, I even tried it with another github user:

May be something wrong was with GitHub?

I've tried Delete Comment button, but it does nothing.
Maybe some additional steps are required to configure the feature on my side?

Probably you don't have rights to delete the comment, I have fixed it by limiting the comment actions by access rights.

[RomanNikitenko]

I tested the changes - I'm able to create, edit and delete a comment - in general it works well for me.
But I faced with the issue that comments were displayed twice, please see a short video

@vinokurig
could you check/test this use case on your side?

[azatsarynnyy]

@vinokurig my issues were related to not enough permissions for my token 😄

Thanks @RomanNikitenko for the advice.
I'll re-check it with the updated token's permissions.

[azatsarynnyy]

I've verified the base functionality:

• add/edit/delete a comment
• start/finish/delete a review

It works fine so far. Additionally, I want to check several more cases...

[vinokurig]

@RomanNikitenko

But I faced with the issue that comments were displayed twice

Thank you, fixed it in my latest commit

[azatsarynnyy]

I've verified that the comments UI duplication is fixed now. Thanks!

[azatsarynnyy]

There's another difference comparing to VS Code.
The comment input hides on focus out. Then it's displayed again once the focus is coming back:

[azatsarynnyy]

In VS Code, the input area hides on focus out, only when it's empty.

[vinokurig]

@azatsarynnyy

In VS Code, the input area hides on focus out, only when it's empty.

Fixed.

[azatsarynnyy]

Thank you @vinokurig for fixing all the issues found during the review.
Everything works well now. 👍

[RomanNikitenko]

@vinokurig
I guess the interface was added by mistake, could you take a look
I created a PR to remove it #9374