Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create navigator widget factory #8962

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Conversation

DoroNahari
Copy link
Contributor

Signed-off-by: Doron Nahari doron.nahari@sap.com

What it does

This pr converts the navigator widget creation to be with a new navigator widget factory which is extensible and so we can extend it and configure it as desired.

How to test

extend:

@injectable()
export class CustomNavigatorWidget extends NavigatorWidgetFactory {
    async createWidget(): Promise<ViewContainer> {
        this.navigatorWidgetOptions = {
            canHide: true,
            initiallyCollapsed: true,
        };
        return super.createWidget();
    }
}

Review checklist

Reminder for reviewers

Copy link
Member

@amiramw amiramw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, how to test can also be:

extend:

@injectable()
export class CustomNavigatorWidget extends NavigatorWidgetFactory {
    protected fileNavigatorWidgetOptions: ViewContainer.Factory.WidgetOptions = {
        canHide: true,
        initiallyCollapsed: true,
    }
}

@vince-fugnitto vince-fugnitto added extensibility issues to simplify ability to extend Theia navigator issues related to the navigator/explorer labels Jan 18, 2021
Signed-off-by: Doron Nahari <doron.nahari@sap.com>
@vince-fugnitto
Copy link
Member

@amiramw would you like to merge the pull-request for tomorrow's release?

@amiramw
Copy link
Member

amiramw commented Jan 27, 2021

@vince-fugnitto yes, we prefer.

@vince-fugnitto
Copy link
Member

@vince-fugnitto yes, we prefer.

I'll let you merge, please go ahead :)

@amiramw amiramw merged commit 85aa2d5 into eclipse-theia:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensibility issues to simplify ability to extend Theia navigator issues related to the navigator/explorer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants