Extract plugin uri generation to injectable class #9027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
extensibility
packages/plugin-ext/src/hosted/node/scanners/plugin-uri-factory.ts
Outdated
Show resolved
Hide resolved
packages/plugin-ext/src/hosted/node/scanners/file-plugin-uri-factory.ts
Outdated
Show resolved
Hide resolved
|
Minor: you've updated copyrights to 2020 in several places, but it should likely be 2021 now. 🎊 |
vinokurig
approved these changes
Feb 5, 2021
tsmaeder
force-pushed
the
16502_plugin_url_factory
branch
from
0de7cbd
to
841213b
Compare
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
force-pushed
the
16502_plugin_url_factory
branch
from
841213b
to
86e015f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Mäder tmader@redhat.com
What it does
Extracts the generation of URIs for contribution files referenced in package.json (like snippet contribution files) to an overrideable class. This would simplify handling remote plugin hosts in Che while not greatly impacting the Theia code.
See eclipse-che/che#16502
How to test
Run theia built from this PR (both electron and browser) and verify that things like snippets, etc. (see https://code.visualstudio.com/api/references/contribution-points) still work.
Review checklist
Reminder for reviewers