Fix writing property on browsers #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade browserify and use readable-stream 4.x.x Workaround to whatwg/fetch#1438 Fix eclipse-thingweb#785 Signed-off-by: reluc <relu.cri@gmail.com>
|
Being just a bug fix I'd go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on the resolution of issue #785. Due to whatwg/fetch#1438 we can't use streams when writing property or invoking an action. Therefore, these changes introduce a specific HttpClient for browsers that override the generateFetchRequest method to read the stream in a buffer.
Moreover, the PR fixes smaller issues:
Readableis forcibly closed the underlying Readable is correctly closed and the error is propagated.Readable.fromis not available in readable-stream v3.x.x so now we are forcing browserify to use the new v4.x.x. That's why in the PR you can see a new build.js script. Its purpose is to properly set up browserify. I couldn't find a way to achieve the same effect using just CLI arguments.