Skip to content

Commit

Permalink
Changed the config file
Browse files Browse the repository at this point in the history
  • Loading branch information
SergioCasCeb committed Feb 2, 2024
1 parent 58df5ed commit 9c893d2
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 63 deletions.
55 changes: 3 additions & 52 deletions .github/workflows/visual-ci-new.yaml
Original file line number Diff line number Diff line change
@@ -1,40 +1,4 @@
# name: web-new Visual Testing Pipeline

# on:
# pull_request:
# paths-ignore:
# - "**.md"
# - "**.png"
# - "**.drawio"
# - "**.xlsx"

# jobs:
# setup-and-visual-test:
# runs-on: ubuntu-latest

# steps:
# - name: Checkout
# uses: actions/checkout@v3

# - name: Use Node.js 18
# uses: actions/setup-node@v3
# with:
# node-version: "18.x"

# - name: Use lerna
# run: npm install -g lerna@6.6.2

# - name: Bootstrap
# run: lerna bootstrap --no-ci

# - name: New Web Visual Test
# timeout-minutes: 18
# run: |
# cd ./packages/web-new
# npm install
# npx playwright install chromium firefox
# npm run test
name: web-new Visual Testing Pipeline
name: Web-New Visual Testing Pipeline

on:
pull_request:
Expand Down Expand Up @@ -64,29 +28,16 @@ jobs:
run: lerna bootstrap --no-ci

- name: Visual Tests
timeout-minutes: 18
run: |
cd ./packages/web-new
npm install
npx playwright install chromium firefox
npm run serve &
sleep 10
npm test
# - name: Run Playwright tests
# run: npm run test

- uses: actions/upload-artifact@v3
if: always()
with:
name: playwright-report
path: playwright-report/
retention-days: 30

# - name: Install dependencies
# run: npm install

# - name: Install Playwright
# run: npx playwright install chromium firefox

# - name: Run Tests
# run: npm run test
retention-days: 30
26 changes: 15 additions & 11 deletions packages/web-new/playwright.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
// @ts-check
const { defineConfig, devices } = require('@playwright/test');

const isCI = process.env.CI;
/**
* Read environment variables from file.
* https://github.com/motdotla/dotenv
*/
// require('dotenv').config();

module.exports = defineConfig({
testDir: './tests',
Expand All @@ -24,11 +28,11 @@ module.exports = defineConfig({
/* Run tests in files in parallel */
fullyParallel: true,
/* Fail the build on CI if you accidentally left test.only in the source code. */
forbidOnly: !!isCI,
forbidOnly: !!process.env.CI,
/* Retry on CI only */
retries: isCI ? 2 : 0,
retries: process.env.CI ? 2 : 0,
/* Opt out of parallel tests on CI. */
workers: isCI ? 1 : undefined,
workers: process.env.CI ? 1 : undefined,
/* Reporter to use. See https://playwright.dev/docs/test-reporters */
reporter: 'html',
/* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
Expand Down Expand Up @@ -64,11 +68,11 @@ module.exports = defineConfig({
// }
],

// /* Run your local dev server before starting the tests */
// webServer: {
// command: 'npm run serve',
// url: 'http://127.0.0.1:5100',
// timeout: 120 * 1000,
// reuseExistingServer: !isCI,
// }
/* Run your local dev server before starting the tests */
webServer: {
command: 'npm run serve',
url: 'http://127.0.0.1:5100',
// timeout: 120 * 1000,
reuseExistingServer: !process.env.CI,
}
});

0 comments on commit 9c893d2

Please sign in to comment.