Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify ThreadX and SMP for ARMv8-A. #275

Merged
merged 7 commits into from
Jun 21, 2023
Merged

Unify ThreadX and SMP for ARMv8-A. #275

merged 7 commits into from
Jun 21, 2023

Conversation

TiejunMS
Copy link
Contributor

PR checklist

  • Updated function header with a short description and version number
  • Added test case for bug fix or new feature
  • Validated on real hardware

@hodcarrier
Copy link

hodcarrier commented Jun 18, 2023

hello, ARMv8-A is hard to type... other projects refers it as armv8-a, gcc's compile option is -march=armv8-a, so why make a new name...
when pass the armv8-a from a environment variable, you have to do one more step:
translate armv8-a to ARMv8-A
eg.
if [ THREADX_ARCH == ARMv8-A ]
CFLAGS += -march=armv8-a
end of if

@TiejunMS
Copy link
Contributor Author

hello, ARMv8-A is hard to type... other projects refers it as armv8-a, gcc's compile option is -march=armv8-a, so why make a new name... when pass the armv8-a from a environment variable, you have to do one more step: translate armv8-a to ARMv8-A eg. if [ THREADX_ARCH == ARMv8-A ] CFLAGS += -march=armv8-a end of if

Thanks for the suggestion! But ports_arch is a folder for internal development only. Users should use files from ports, ports_module and ports_smp.

@TiejunMS TiejunMS force-pushed the tizho/unify_armv8a branch from 79f7bc6 to 78f4a90 Compare June 19, 2023 06:30
@TiejunMS TiejunMS marked this pull request as ready for review June 21, 2023 05:23
@TiejunMS TiejunMS requested a review from bo-ms June 21, 2023 05:23
@TiejunMS TiejunMS merged commit 08380ca into master Jun 21, 2023
@TiejunMS TiejunMS deleted the tizho/unify_armv8a branch June 21, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants