Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmf: Fix stream orElse(null) errors #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PatrickTasse
Copy link
Contributor

@PatrickTasse PatrickTasse commented May 17, 2024

It seems that filter(Objects::nonNull) now changes the stream type to a <@nonnull E>, so that orElse(null) is no longer allowed. Change to check the optional presence before returning null.

This change requires an upgrade to Tycho 4.0.9.

MatthewKhouzam
MatthewKhouzam previously approved these changes Jun 12, 2024
Copy link
Contributor

@MatthewKhouzam MatthewKhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this cleaner.

It seems that filter(Objects::nonNull) now changes the stream type to a
<@nonnull E>, so that orElse(null) is no longer allowed. Change to check
the optional presence before returning null.

This change requires an upgrade to Tycho 4.0.9.

Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants