Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analysis.graph: Cleanup non-API deprecation issues in dependency graph #91

Merged
merged 1 commit into from
May 24, 2024
Merged

analysis.graph: Cleanup non-API deprecation issues in dependency graph #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...org/eclipse/tracecompass/analysis/graph/core/criticalpath/AbstractCriticalPathModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
import org.eclipse.tracecompass.analysis.graph.core.graph.WorkerSerializer;
import org.eclipse.tracecompass.common.core.NonNullUtils;
import org.eclipse.tracecompass.internal.analysis.graph.core.Activator;
import org.eclipse.tracecompass.internal.analysis.graph.core.criticalpath.CriticalPathModule;
import org.eclipse.tracecompass.internal.analysis.graph.core.criticalpath.Messages;
import org.eclipse.tracecompass.internal.analysis.graph.core.criticalpath.OSCriticalPathAlgorithm;
import org.eclipse.tracecompass.tmf.core.analysis.TmfAbstractAnalysisModule;
import org.eclipse.tracecompass.tmf.core.exceptions.TmfAnalysisException;
import org.eclipse.tracecompass.tmf.core.trace.ITmfTrace;
import org.eclipse.tracecompass.tmf.core.trace.TmfTraceManager;
Expand All @@ -41,7 +41,13 @@
* @author Geneviève Bastien
* @since 4.0
*/
public abstract class AbstractCriticalPathModule extends CriticalPathModule {
public abstract class AbstractCriticalPathModule extends TmfAbstractAnalysisModule implements ICriticalPathProvider {

/**
* Analysis ID for this module
* @since 5.0
*/
public static final String ANALYSIS_ID = "org.eclipse.tracecompass.analysis.graph.core.criticalpath"; //$NON-NLS-1$

/** Worker_id parameter name */
public static final String PARAM_WORKER = "workerid"; //$NON-NLS-1$
Expand All @@ -62,7 +68,6 @@ public abstract class AbstractCriticalPathModule extends CriticalPathModule {
* @since 1.1
*/
public AbstractCriticalPathModule(AbstractTmfGraphBuilderModule graph) {
super(graph);
addParameter(PARAM_WORKER);
setId(ANALYSIS_ID);
fGraphModule = graph;
Expand Down
31 changes: 0 additions & 31 deletions ...e/src/org/eclipse/tracecompass/internal/analysis/graph/core/base/CriticalPathPalette.java
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions ...s.graph.core/src/org/eclipse/tracecompass/internal/analysis/graph/core/base/TmfGraph.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
import org.eclipse.tracecompass.analysis.graph.core.graph.ITmfGraph;
import org.eclipse.tracecompass.analysis.graph.core.graph.ITmfGraphVisitor;
import org.eclipse.tracecompass.analysis.graph.core.graph.ITmfVertex;
import org.eclipse.tracecompass.analysis.graph.core.graph.TmfGraphFactory;
import org.eclipse.tracecompass.common.core.NonNullUtils;
import org.eclipse.tracecompass.internal.analysis.graph.core.base.TmfEdge.EdgeType;
import org.eclipse.tracecompass.internal.analysis.graph.core.base.TmfVertex.EdgeDirection;
Expand All @@ -55,10 +54,7 @@
*
* @author Francis Giraldeau
* @author Geneviève Bastien
* @deprecated Use the {@link ITmfGraph} API instead, and the
* {@link TmfGraphFactory} to create new graphs.
*/
@Deprecated
public class TmfGraph {

private final ListMultimap<IGraphWorker, TmfVertex> fNodeMap;
Expand Down
98 changes: 0 additions & 98 deletions ...rg/eclipse/tracecompass/internal/analysis/graph/core/criticalpath/CriticalPathModule.java
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a link in the javadoc to this file that should be changed as well:

org.eclipse.tracecompass/analysis/org.eclipse.tracecompass.analysis.graph.core/src/org/eclipse/tracecompass/internal/analysis/graph/core/dataprovider/CriticalPathDataProvider.java

Line 154 in f5c4c28

* Get the current {@link IGraphWorker} from the {@link CriticalPathModule}

This file was deleted.

4 changes: 2 additions & 2 deletions ...ipse/tracecompass/internal/analysis/graph/core/dataprovider/CriticalPathDataProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**********************************************************************
* Copyright (c) 2018, 2022 Ericsson
* Copyright (c) 2018, 2024 Ericsson
*
* All rights reserved. This program and the accompanying materials are
* made available under the terms of the Eclipse Public License 2.0 which
Expand Down Expand Up @@ -151,7 +151,7 @@ public CriticalPathDataProvider(@NonNull ITmfTrace trace, @NonNull AbstractCriti
}

/**
* Get the current {@link IGraphWorker} from the {@link CriticalPathModule}
* Get the current {@link IGraphWorker} from the critical path module
*
* @return the current graph worker if it is set, else null.
*/
Expand Down
1 change: 0 additions & 1 deletion ...eclipse/tracecompass/internal/analysis/graph/core/graph/legacy/TmfGraphLegacyWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
*
* @author Geneviève Bastien
*/
@SuppressWarnings("deprecation")
public class TmfGraphLegacyWrapper implements ITmfGraph {

/* Latch tracking if the graph is done building or not */
Expand Down
Loading