Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(usage policy): Duration removed #57

Merged
merged 2 commits into from
Jan 4, 2024
Merged

fix(usage policy): Duration removed #57

merged 2 commits into from
Jan 4, 2024

Conversation

ajithsimons
Copy link
Contributor

@ajithsimons ajithsimons commented Jan 2, 2024 •
edited
Loading

Description

  • Duration usage policy removed since it is invalid from EDC side.
  • End date in contracts list removed because it was calculated from duration policy.

Pre-review checks

@ajithsimons
Copy link
Contributor Author

Merge this after #56

adityagajbhiye9
adityagajbhiye9 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sachinargade123
sachinargade123 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityagajbhiye9 adityagajbhiye9 requested review from almadigabor and removed request for hzierer and FaGru3n January 4, 2024 08:08
almadigabor
almadigabor approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@almadigabor almadigabor merged commit 7793429 into eclipse-tractusx:main Jan 4, 2024
4 checks passed
@almadigabor almadigabor deleted the bugfix/usage-duration branch January 4, 2024 14:04
@ajithsimons ajithsimons self-assigned this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityagajbhiye9 adityagajbhiye9 adityagajbhiye9 approved these changes

@sachinargade123 sachinargade123 sachinargade123 approved these changes

@almadigabor almadigabor almadigabor approved these changes

Assignees

@ajithsimons ajithsimons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajithsimons @almadigabor @sachinargade123 @adityagajbhiye9