Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add openapi spec link to metadata file #1385

Merged
merged 1 commit into from
Jul 1, 2024
Merged

docs: add openapi spec link to metadata file #1385

merged 1 commit into from
Jul 1, 2024

Conversation

ndr-brt
Copy link
Contributor

@ndr-brt ndr-brt commented Jun 28, 2024

WHAT

Adds openApiSpecs link in .tractusx metadata fiile

WHY

documentation

FURTHER NOTES

  • ensured that on every version release the version number will be bumped

Closes #1384

@ndr-brt ndr-brt added the documentation Improvements or additions to documentation label Jun 28, 2024
tomaszbarwicki
tomaszbarwicki approved these changes Jun 28, 2024
View reviewed changes
Copy link

@tomaszbarwicki tomaszbarwicki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however would suggest to upload/link OpenAPI spec directly from repo. The whole concept is to become idependent of swaggerhub.

@ndr-brt
Copy link
Contributor Author

ndr-brt commented Jul 1, 2024

LGTM, however would suggest to upload/link OpenAPI spec directly from repo. The whole concept is to become idependent of swaggerhub.

I think our best choice would be to publish it on github pages instead of keep it in the repository anyway, but currently it's uploaded on swaggerhub and it does not hurt anybody.

@ndr-brt ndr-brt merged commit 2190dc5 into eclipse-tractusx:main Jul 1, 2024
33 checks passed
@ndr-brt ndr-brt deleted the 733-add-openapi-spec-to-metadata branch July 1, 2024 07:55
paullatzelsperger pushed a commit to paullatzelsperger/tractusx-edc that referenced this pull request Jul 2, 2024
@ndr-brt @paullatzelsperger
docs: add openapi spec link to metadata file (eclipse-tractusx#1385)
7c8101f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszbarwicki tomaszbarwicki tomaszbarwicki approved these changes

@wolf4ood wolf4ood Awaiting requested review from wolf4ood

@paullatzelsperger paullatzelsperger Awaiting requested review from paullatzelsperger

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
EDC PR Board
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add openapi spec to .tractusx file
2 participants
@ndr-brt @tomaszbarwicki