Fix: Backport Add Persistence for DataplaneSelector. #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale because it has been open for 7 days with no activity. |
rafaelmag110
force-pushed
the
feature/Backport_Add_Persistence_for_dataplaneselector
branch
from
9af5c40
to
33e6360
Compare
… of github.com:bmg13/tractusx-edc into feature/Backport_Add_Persistence_for_dataplaneselector
|
@paullatzelsperger @wolf4ood can you please review? 🙇 |
wolf4ood
approved these changes
Aug 22, 2024
| @@ -0,0 +1,20 @@ | |||
| ################################################################################# | |||
| # Copyright (c) 2023 Bayerische Motoren Werke Aktiengesellschaft (BMW AG) | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2023 Bayerische Motoren Werke Aktiengesellschaft (BMW AG) | |
| # Copyright (c) 2024 Bayerische Motoren Werke Aktiengesellschaft (BMW AG) |
There was a problem hiding this comment.
Nice catch, thank you! Changed in 040a502
Co-authored-by: Enrico Risa <enrico.risa@gmail.com>
|
|
@wolf4ood can you rerun the failing job? |
|
@wolf4ood can this be merged, please? |
|
@bmg13 done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This PR backports the added DataPlane instance selector logic to the v0.7.4.
WHY
To avoid the dataplane registry only in one ControlPlane in memory, this change enables the storage of DataPlane's availability in the bd. So, there should be enabled SQL persistence for data-plane-selector in backported 0.7.4 version.
FURTHER NOTES
Logic here is partially extracted from #1475 PR
Closes #1497