-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update up-client-zenoh-rust with up-spec 1.5.7 #21
Update up-client-zenoh-rust with up-spec 1.5.7 #21
Conversation
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@PLeVasseur I think the PR is ready. There are a lot of changes, but it should not affect your uStreamer implementation since I didn't change the API (except removing RpcServer) Here are the modifications:
Hope it's compatible with your uStreamer implementation |
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
…tener Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@PLeVasseur I think the PR is ready for your second review 😄 |
Finished round 2 -- looking good 🙂 Had one item that I think would be good to check on: |
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@PLeVasseur Thank you! Let me know if you have any other comments. |
Hey @evshary -- I missed this tiny nitpick which I think gives symmetry. Could you take a look? |
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@PLeVasseur Done and your comment also reminds me to remove some TODO in code since eclipse-uprotocol/up-rust#75 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@stevenhartley Could you help me to merge the PR? I would like to work on eclipse-uprotocol/up-spec#103 based on the PR's changes. |
Since up-rust is upgraded to up-spec 1.5.7 in eclipse-uprotocol/up-rust#66, the PR is to keep the code updated.
I'll update https://github.com/eclipse-uprotocol/up-zenoh-example-rust later