-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we Bring Back Short Form URI? #83
Comments
From Zenoh perspective, using the short URI is easier to generate Zenoh key.
However, I'm just wondering whether this will cause a problem for users if they need to define Long/Short/Micro format while declaring the UURI? |
I think this makes a lot of sense for protocols like MQTT and Zenoh. @evshary -- btw, just wanted to make sure that you're still able to take a UUri containing only a UAuthority and still form a Zenoh KeyExpr then like this: You may need to submit a PR upstream to |
Hi @PLeVasseur
I think I still need to do some minor transformations.
The main reason is that
Do you mean short form? |
Makes sense to me.
Perhaps? I'm unclear on if long and short form differ when it comes to the UAuthority, since it seems like in any case they are turned into string representations. |
Yes, but only the IP format is available in short form. While considering long form, we might need to deal with some special characters. |
Oh really? I think it's also possible to use the id. Basically either of the two numeric representations of UAuthority, ip or id. I think @stevenhartley answered that way to @tamarafischer when it came up in our meeting. |
I saw it from the old spec. Maybe we can check with @stevenhartley |
this change also copies over the legal documents and fixes up other parts of the specification. #83
* Add back Short Form URI this change also copies over the legal documents and fixes up other parts of the specification. #83 * Removed zombie file * Address comments and put examples back together.
resolved in the spec |
Older version of uri.adoc use to also have a URI format called Short Form. Short URI was a string representation of the numbers inside of UUri object, example below:
up://192.168.1.100/2/1.1/5000
In the above example. UAuthority was the IP address, uService id is 2, verison of the service is 1.1, and the topic ID (the publish topic) was 5000.
It was thought that this version would not be needed so it was removed from up-java and the specification however we see strong benefits of this URI format for zenoh and MQTT that require strings for topic names.
This issue is to address if we should bring back short form URIs for zenoh & MQTT (and possibly other transports) in lieu of micro form that is difficult to use unless you're writing raw bytes to a transport "wire".
The text was updated successfully, but these errors were encountered: