Add Zenoh spec to uProtocol #52
Conversation
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
|
PR to address #21 |
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
|
Thanks @evshary, I think it's just about there. 🙂 I think adding a link to the appropriate part of the |
up-l1/zenoh.adoc
Outdated
| === Zenoh Config | ||
|
|
||
| While constructing the UPClientZenoh object, the Zenoh config needs to be assigned. |
There was a problem hiding this comment.
This section will need to be outlined a little bit more. Perhaps for now we can remove it and then add it in later (so we have a starting ground to build on top of?)
There was a problem hiding this comment.
Okay. I think removing this part in the initial version will not affect the interoperability.
Why we need Zenoh config is that we need a way to configure how Zenoh works.
Let's discuss it a bit more in the meeting.
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
|
@stevenhartley @PLeVasseur Thanks for your review. Maybe we can discuss the rest reviews in the weekly meeting. |
| @@ -5,7 +5,7 @@ | |||
| The key words "*MUST*", "*MUST NOT*", "*REQUIRED*", "*SHALL*", "*SHALL NOT*", "*SHOULD*", "*SHOULD NOT*", "*RECOMMENDED*", "*MAY*", and "*OPTIONAL*" in this document are to be interpreted as described in https://www.rfc-editor.org/info/bcp14[IETF BCP14 (RFC2119 & RFC8174)] | |||
|
|
|||
| ---- | |||
| Copyright (c) 2023 General Motors GTO LLC | |||
| Copyright (c) 2024 ZettaScale Technology | |||
There was a problem hiding this comment.
I would suggest to use
SPDX-FileCopyrightText: 2024 Contributors to the Eclipse Foundation
as suggested by https://www.eclipse.org/projects/handbook/#ip-copyright-headers and https://reuse.software/tutorial/#step-2 and then remove the redundant entry below the license header.
There was a problem hiding this comment.
Do you mean removing the line SPDX-FileCopyrightText: 2024 Contributors to the Eclipse Foundation and only use Copyright (c) 2024 Contributors to the Eclipse Foundation instead?
There was a problem hiding this comment.
I mean to replace line
Copyright (c) 2024 ZettaScale Technology
with
SPDX-FileCopyrightText: 2024 Contributors to the Eclipse Foundation
There was a problem hiding this comment.
I would suggest to use
SPDX-FileCopyrightText: 2024 Contributors to the Eclipse Foundationas suggested by https://www.eclipse.org/projects/handbook/#ip-copyright-headers and https://reuse.software/tutorial/#step-2 and then remove the redundant entry below the license header.
@sophokles73 I'll add this best practice to the CONTRIBUTING.adoc in .github and then slowly update all the projects to point to this CONTRIBUTING.adoc file.
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
|
@stevenhartley @PLeVasseur The spec is updated. Let me now if there is anything missing. |
|
Yeah, I think if you update the copyright header as suggested by Kai, I think we're good 🙂 |
| @@ -5,7 +5,7 @@ | |||
| The key words "*MUST*", "*MUST NOT*", "*REQUIRED*", "*SHALL*", "*SHALL NOT*", "*SHOULD*", "*SHOULD NOT*", "*RECOMMENDED*", "*MAY*", and "*OPTIONAL*" in this document are to be interpreted as described in https://www.rfc-editor.org/info/bcp14[IETF BCP14 (RFC2119 & RFC8174)] | |||
|
|
|||
| ---- | |||
| Copyright (c) 2023 General Motors GTO LLC | |||
| Copyright (c) 2024 ZettaScale Technology | |||
There was a problem hiding this comment.
I would suggest to use
SPDX-FileCopyrightText: 2024 Contributors to the Eclipse Foundationas suggested by https://www.eclipse.org/projects/handbook/#ip-copyright-headers and https://reuse.software/tutorial/#step-2 and then remove the redundant entry below the license header.
@sophokles73 I'll add this best practice to the CONTRIBUTING.adoc in .github and then slowly update all the projects to point to this CONTRIBUTING.adoc file.
The PR is not ready to be merged, but I think it would be easier to discuss the spec if we open a draft PR.
I'll keep working on
uprotocol-rust-ulink-zenohand updating the spec here.Feel free to add any comments on this.