Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test case regression #150

Closed

Conversation

erikbosch
Copy link
Contributor

In https://github.com/eclipse-velocitas/devenv-devcontainer-setup/releases/tag/v2.5.0 files have been removed, and when we do create we automatically updates to latest and greatest

In https://github.com/eclipse-velocitas/devenv-devcontainer-setup/releases/tag/v2.5.0
files have been removed, and when we do create we automatically updates to latest and greatest
@erikbosch erikbosch marked this pull request as ready for review September 5, 2024 11:39
@BjoernAtBosch
Copy link
Member

Maybe we should "restore" the postStartCommand.sh and call the update-cli.sh from there - would be more backwards compatible ...

@erikbosch erikbosch marked this pull request as draft September 6, 2024 08:22
@erikbosch
Copy link
Contributor Author

This PR is put on hold for now but kept open for reference. Main approach now is to restore postStartCommand.sh. When done and https://github.com/eclipse-velocitas/vehicle-app-python-sdk/actions/workflows/project-creation.yaml succeeds again this PR can be closed

@erikbosch
Copy link
Contributor Author

Change no longer needed

@erikbosch erikbosch closed this Sep 6, 2024
@BjoernAtBosch BjoernAtBosch deleted the erik_fix branch September 6, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants