Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies to fix vulnerabilities #151

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented Oct 2, 2024

There are some hypothetical vulnerabilities in v0.14.1 of this repo, so the examples and skeleton should preferably not use that one. I have just updated it to last release version (examples are anyway partially broken, see #141 )

We should better discuss how to handle these references when we do releases. Should we always update them before/after we create a new pypi release? Or should we in these two cases just remove version so we use "latest and greatest" velocitas-sdk

@erikbosch erikbosch marked this pull request as ready for review October 2, 2024 08:21
@erikbosch
Copy link
Contributor Author

@BjoernAtBosch - this was the starting point for the wiki definition - that I realized that we somewhere should document when to update these two version labels.

(As of today I think we can update them before we make a release as we do not test them in CI, but that might be more cumbersome if we actually starts testing them in CI as the new version do not yet exist in pypi when CI is run. I guess the examples better fit in another repo, especially as some of them like https://github.com/eclipse-velocitas/vehicle-app-python-sdk/tree/main/examples/seat-adjuster explicitly says that they cnanot be used from the sdk)

Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikbosch erikbosch merged commit cf7e2ff into eclipse-velocitas:main Oct 4, 2024
8 checks passed
@erikbosch erikbosch deleted the erik_dep branch October 4, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants