Feature/11237 datapoint setter #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emsameen
force-pushed
the
feature/11237-datapoint-setter
branch
2 times, most recently
from
82f71ad to
2841e9c
Compare
emsameen
force-pushed
the
feature/11237-datapoint-setter
branch
from
2841e9c to
18f4d6c
Compare
emsameen
commented
Oct 25, 2022
| @@ -21,7 +21,7 @@ | |||
| { | |||
| "name": "databroker", | |||
| "image": "ghcr.io/eclipse/kuksa.val/databroker", | |||
| "version": "v0.17.0" | |||
| "version": "master" | |||
There was a problem hiding this comment.
This needs to be updated according to the new VAL version.
- Soon you shall receive a new version
| { | ||
| "name": "databroker", | ||
| "image": "ghcr.io/eclipse/kuksa.val/databroker", | ||
| "version": "master" |
There was a problem hiding this comment.
This needs to be updated according to the new VAL version.
- Soon you shall receive a new version
| @@ -229,6 +239,28 @@ async def get(self): | |||
| ) | |||
| raise | |||
|
|
|||
| async def set(self, value): | |||
There was a problem hiding this comment.
As discussed in the further improvement for this to make the set method only visible for the actuator data points, this requires additional adaptation on the Vehicle mode and needs also alignment with the C++
dennismeister93
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implement SetDatapoint API to enable value set of the vss actuators.
Issue ticket number and link
#11237
Checklist - Manual tasks