Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dictionary initialization #7

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Fix dictionary initialization #7

merged 4 commits into from
Jul 26, 2022

Conversation

DocMoebiuz
Copy link
Contributor

@DocMoebiuz DocMoebiuz commented Jul 20, 2022 •
edited
Loading

Describe your changes

SDK Dictionary initialization is now using simple Lists of strings and is compatible with the current version of the Python Vehicle Model Generator.

Issue ticket number and link

Fixes #6

Checklist - Manual tasks

  • Examples are executing successfully
  • Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.
  • Created/updated integration tests. does not apply
  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy no changes were made
  • Devcontainer can be re-built successfully
  • Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas), see Missing example how SDK allows to access Vehicle Model branches  velocitas-docs#17

@DocMoebiuz DocMoebiuz changed the title Dictionary access fix Fix dictionary initialization Jul 20, 2022
@emsameen emsameen self-requested a review July 25, 2022 09:44
emsameen
emsameen requested changes Jul 25, 2022
View reviewed changes
Copy link
Member

@emsameen emsameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI workflow

@DocMoebiuz
Copy link
Contributor Author

Please fix the CI workflow

@emsameen done. Please review the PR again.

@DocMoebiuz DocMoebiuz requested a review from emsameen July 25, 2022 18:43
emsameen
emsameen approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@emsameen emsameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DocMoebiuz DocMoebiuz merged commit 561fc87 into main Jul 26, 2022
@DocMoebiuz DocMoebiuz deleted the dictionary-access-fix branch July 26, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emsameen emsameen emsameen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistent Dictionary initialization in Vehicle Model Generator and SDK
2 participants
@DocMoebiuz @emsameen