Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 'Name' attribute in examples to 'name' (lowercase) #86

Merged
merged 1 commit into from
Jun 8, 2023
Merged

[Fix] 'Name' attribute in examples to 'name' (lowercase) #86

merged 1 commit into from
Jun 8, 2023

Conversation

BjoernAtBosch
Copy link
Member

Describe your changes

Fix name attribute in examples to lowercase

Issue ticket number and link

AB#15092

Checklist - Manual tasks

  • Examples are executing successfully
  • Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.
  • Created/updated integration tests.
  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy
  • Devcontainer can be re-built successfully
  • Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas)

kse3hi
kse3hi approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@kse3hi kse3hi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BjoernAtBosch BjoernAtBosch merged commit 4191bb9 into main Jun 8, 2023
@BjoernAtBosch BjoernAtBosch deleted the fix/lowercase_name_attribute branch June 8, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kse3hi kse3hi kse3hi approved these changes

@dennismeister93 dennismeister93 Awaiting requested review from dennismeister93

@MP91 MP91 Awaiting requested review from MP91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BjoernAtBosch @kse3hi