Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update baseimage as for tagging strategy (v0.1) #92

Closed
wants to merge 3 commits into from
Closed

Update baseimage as for tagging strategy (v0.1) #92

wants to merge 3 commits into from

Conversation

kse3hi
Copy link
Contributor

@kse3hi kse3hi commented Jul 26, 2023 •
edited
Loading

ADO#15208

Describe your changes

Issue ticket number and link

Checklist - Manual tasks

  • Examples are executing successfully
  • Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.
  • Created/updated integration tests.
  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy
  • Devcontainer can be re-built successfully
  • Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas)

doosuu
doosuu previously approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@doosuu doosuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doosuu
doosuu approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@doosuu doosuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MP91
Copy link
Contributor

MP91 commented Aug 30, 2023

done with #100

@MP91 MP91 closed this Aug 30, 2023
@kse3hi kse3hi deleted the update/baseimage branch January 23, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doosuu doosuu doosuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kse3hi @MP91 @doosuu