App manifest v3 #95
App manifest v3 #95
Conversation
Yes, at least all are starting correctly without any errors. |
| { | ||
| "type": "grpc-interface", | ||
| "config": { | ||
| "src": "https://github.com/eclipse/kuksa.val/blob/master/kuksa_databroker/proto/sdv/databroker/v1/broker.proto", | ||
| "required": { | ||
| "methods": [ | ||
| "Subscribe" | ||
| ] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I thought, this should go out. Databroker interface is "implicitly" defined by referencing the VSS model.
@doosuu: Or?
There was a problem hiding this comment.
Hmm I was not aware of this discussion, but in the concept nothing is written about that...
There was a problem hiding this comment.
Yes, databroker is not an explicit dependency.
| { | ||
| "type": "grpc-interface", | ||
| "config": { | ||
| "src": "https://github.com/eclipse/kuksa.val/blob/master/kuksa_databroker/proto/sdv/databroker/v1/broker.proto", |
There was a problem hiding this comment.
In case that we keep the databroker interface "referencing" here (see my other finding), shouldn't we specify a fixed version of the proto source (instead of "master")?
There was a problem hiding this comment.
Master just refers to the repository. I expect the v1 in "proto/sdv/databroker/v1/broker.proto" to be updated if something in the interface changes
There was a problem hiding this comment.
Yes and no: "v1" is just a major version, whose purpose is to allow to maintain multiple major versions in parallel.
A version "v2" is added once some incompatible change is done in the interface. As long as there are only compatible changes the interface is still maintained as "v1". (There are no minor or patch versions at this level.)
Function-wise this should not harm, as the app still uses the "old" interface (and exactly specifies the methods used). But the advantage of pinning the exact version would be reproducibility. Maybe this is more relevant for C++, because if a new compatible version is released on master ("under the hood" of v1), this will end up in re-compilation.
Describe your changes
Updates the AppManifest in all examples to v3
Issue ticket number and link
Checklist - Manual tasks