Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade protobuf and grpcio #99

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Upgrade protobuf and grpcio #99

merged 6 commits into from
Aug 30, 2023

Conversation

kse3hi
Copy link
Contributor

@kse3hi kse3hi commented Aug 28, 2023

Describe your changes

Update grpcio to avoid security issues

Issue ticket number and link

ADO#15657

Checklist - Manual tasks

  • Examples are executing successfully
  • Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.
  • Created/updated integration tests.
  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy
  • Devcontainer can be re-built successfully
  • Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas)

@kse3hi kse3hi added the enhancement New feature or request label Aug 28, 2023
@kse3hi kse3hi self-assigned this Aug 28, 2023
MP91
MP91 reviewed Aug 28, 2023
View reviewed changes
setup.py Outdated Show resolved Hide resolved
BjoernAtBosch
BjoernAtBosch reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions to be clarified

setup.py Show resolved Hide resolved
.vscode/launch.json Show resolved Hide resolved
@MP91 MP91 mentioned this pull request Aug 30, 2023
Closed
7 tasks
BjoernAtBosch
BjoernAtBosch previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BjoernAtBosch
BjoernAtBosch approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kse3hi kse3hi merged commit 549820c into main Aug 30, 2023
@kse3hi kse3hi deleted the upgrade/protobuf branch August 30, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MP91 MP91 MP91 left review comments

@BjoernAtBosch BjoernAtBosch BjoernAtBosch approved these changes

Assignees

@kse3hi kse3hi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kse3hi @MP91 @BjoernAtBosch