Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove URL dependency to vss-tools #55

Merged
merged 2 commits into from
May 22, 2024
Merged

Remove URL dependency to vss-tools #55

merged 2 commits into from
May 22, 2024

Conversation

doosuu
Copy link
Member

@doosuu doosuu commented May 21, 2024 •
edited
Loading

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

@doosuu doosuu requested a review from dennismeister93 May 21, 2024 20:34
dennismeister93
dennismeister93 approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@doosuu doosuu merged commit d0bfce6 into main May 22, 2024
5 checks passed
@doosuu doosuu deleted the remove-vss-tools-url branch May 22, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennismeister93 dennismeister93 dennismeister93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doosuu @dennismeister93