-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 5163 configurable socket keepalive interval #5183
Open
aksabg
wants to merge
3
commits into
eclipse-vertx:4.x
Choose a base branch
from
aksabg:feature-5163-configurable-socket-keepalive-interval
base: 4.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature 5163 configurable socket keepalive interval #5183
aksabg
wants to merge
3
commits into
eclipse-vertx:4.x
from
aksabg:feature-5163-configurable-socket-keepalive-interval
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…conds, tcpKeepAliveIntervalSeconds
* 4.x: Add option for whether semicolon is treated as normal character or not HTTP/1 server request does execute twice the delivery of the content to the handler. Set version to 4.5.8-SNAPSHOT Releasing 4.5.7 Native image metadata should be in a vertx jar with the native-image classifier instead of the default jar artifact. A Vertx uses cached reflection to build the virtual thread factory in order to remain compatible with Java 8. When running in a native image Vert.x will assume that the runtime might not have virtual thread incorrectly. Fix a regression in HttpServerRequest#isExpectMultipart due to the cleanup of the form.
vietj
reviewed
Apr 11, 2024
vietj
reviewed
Apr 11, 2024
jakub-id
suggested changes
Jun 30, 2024
bootstrap.childOption(EpollChannelOption.TCP_KEEPIDLE, options.getTcpKeepAliveIdleSeconds()); | ||
} | ||
if (options.isTcpKeepAlive() && options.getTcpKeepAliveCount() != -1) { | ||
bootstrap.childOption(EpollChannelOption.TCP_KEEPCNT, options.getTcpKeepAliveIdleSeconds()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be getTcpKeepAliveCount
bootstrap.childOption(EpollChannelOption.TCP_KEEPCNT, options.getTcpKeepAliveIdleSeconds()); | ||
} | ||
if (options.isTcpKeepAlive() && options.getTcpKeepAliveIntervalSeconds() != -1) { | ||
bootstrap.childOption(EpollChannelOption.TCP_KEEPINTVL, options.getTcpKeepAliveIdleSeconds()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be getTcpKeepAliveIntervalSeconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature according to: github.com/eclipse-vertx/vert.x/issues/5163