Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring Netty compression content size threshold #5303

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wvuong
Copy link

@wvuong wvuong commented Sep 9, 2024

Motivation:

Netty allows you to customize the minimum content size threshold for compression via a constructor arg in HttpContentCompressor. Configuring this means that Netty won't compress responses if they are below the size threshold which can be useful for small responses where the CPU vs saved bytes tradeoff is not good. The Netty default is 0 which I carried on here. I also updated the documentation.

Conformance:

I have signed the Eclipse Contributor Agreement.

@vietj
Copy link
Member

vietj commented Nov 19, 2024

@wvuong we need a test for this that checks that the threshold is taken in account

@vietj vietj added this to the 5.0.0 milestone Nov 19, 2024
@wvuong
Copy link
Author

wvuong commented Nov 19, 2024

Sure, I'll put something together in the next day or two.

@vietj
Copy link
Member

vietj commented Nov 19, 2024

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants