-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCSS formatter #237
Comments
It was a long time but I created an issue for vscode CSS LS to support formatting. The idea is to configure the CSS Language Server with a JS formatter like jsbeautify or prettier. See microsoft/vscode-css-languageservice#44 and microsoft/vscode#39088 but it requires a PR. Once this PR will be done, we could having formatting for CSS with LS without adding extra code. |
As @angelozerr , this is something that needs to be fixed upstream, in VSCode language Servers. |
For HTML as well? I see why this would be desirable in the LS, but wouldn't it make sense to also provide some other formatter as well? See tons of VSCode plugins... |
The scope of Wild Web Developer is to leverage language servers and redirect most language smartness effort into the language server. So, yes, even for HTML, Wild Web Developer won't use or host another formatter. If some want to put some development effort to implement formatting, then this effort has to be directed to VSCode, and then Wild Web Developer will enable it for free. |
+1 for the suggestion. @mickaelistria can you open an upstream bug? |
@mickaelistria it seems vscode supports html format. It seems that it is enable with dynamic settings https://github.com/microsoft/vscode/blob/master/extensions/html-language-features/server/src/htmlServerMain.ts#L175 |
Thanks a lot for those pieces of information @angelozerr . I'm preparing a PR to enable HTML formatting. |
Thanks to @angelozerr 's hint, HTML formatter was added and will be available in next snapshots (and next release). |
Awesome! Thanks Angelo and Mickael.
…On Fri, Sep 6, 2019 at 10:15 AM Mickael Istria ***@***.***> wrote:
Thanks to @angelozerr 's hint, HTML formatter was added and will be available in next snapshots (and next release).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
--
Eclipse Platform project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@vogella.com, Web: http://www.vogella.com
|
So HTML is supported and CSS is tracked in #38 , let's close. |
My current PR #925 (comment) activate CSS formatter but without preferences. |
Hey,
as far as I can see there is no option to format neither HTML nor SCSS.
Maybe it is possible to use prettier for this?
The text was updated successfully, but these errors were encountered: