Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css] API/configuration to extend the CSS language server #39088

Closed
aeschli opened this issue Nov 24, 2017 · 6 comments
Closed

[css] API/configuration to extend the CSS language server #39088

aeschli opened this issue Nov 24, 2017 · 6 comments
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Nov 24, 2017

microsoft/vscode-css-languageservice#44 wants to extend the CSS language server with a formatter.

@vscodebot vscodebot bot added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Nov 24, 2017
@aeschli aeschli self-assigned this Nov 24, 2017
@aeschli aeschli added this to the Backlog milestone Nov 24, 2017
@aeschli aeschli added css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality and removed css-less-scss Issues and items concerning CSS,Less,SCSS styling labels Nov 24, 2017
@aeschli aeschli added the help wanted Issues identified as good community contribution opportunities label Nov 24, 2017
@aeschli aeschli changed the title API/configuration to extend the CSS language server [css] API/configuration to extend the CSS language server Dec 1, 2017
@octref
Copy link
Contributor

octref commented May 10, 2018

@aeschli Would you want to use prettier which has support for css/scss/less for this one? Vetur is using prettier and people like it.

@aeschli
Copy link
Contributor Author

aeschli commented May 14, 2018

This is just about adding API so that other products can add it to the language server.
For VSCode this should come from an extension.

@octref
Copy link
Contributor

octref commented May 14, 2018

Do you mean having extension contributing to the css-language-feature extension? I don't feel that complexity is needed. The real blocker is #41882 which doesn't handle multiple formatter as good as we do for completion items / hover. IMO a better solution should be making it possible for multiple registrations of formatters, and making the formatters selectable.

@aeschli
Copy link
Contributor Author

aeschli commented May 14, 2018

It's about new language server API. See microsoft/vscode-css-languageservice#44 as the motivation for this request.

@octref
Copy link
Contributor

octref commented Oct 21, 2019

I don't think this would happen any time soon, or should happen at all.

  1. From CSS Format support vscode-css-languageservice#44 it seems @angelozerr still wants CSS LS to bundle a few formatters out-of-the-box, thus all formatter failure blames are on VS Code.
  2. Let's say we have such a setting css.formatter where you can choose among an enum. How does it resolve formatting settings? Under some options in css (do we have to add settings for all formatters under css.*?) or if I'm using css.formatter: "prettier", prettier.* options? How can users understand how the settings are applied?
  3. We don't easily bundle external features/dependencies into VS Code, if the functionality is easily implementable by an extension. In this case, you can write another Language Server for CSS just for formatting.

@octref octref added *out-of-scope Posted issue is not in scope of VS Code and removed help wanted Issues identified as good community contribution opportunities labels Oct 21, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 21, 2019

We closed this issue because we don't plan to address it in the foreseeable future. You can find more detailed information about our decision-making process here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

2 participants