Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vscode-js-debug in place of deprecated node-debug2 #1174

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Use vscode-js-debug in place of deprecated node-debug2 #1174

merged 1 commit into from
Oct 8, 2023

Conversation

mickaelistria
Copy link
Contributor

This was drafted while working on startDebugging support for LSP4E.
Before we can merge in Wild Web Developer, this requires the following issues to be fixed

@mickaelistria mickaelistria linked an issue Apr 18, 2023 that may be closed by this pull request
Replace node debug adapters with vscode-js-debug adapter #555
Closed
@mickaelistria mickaelistria mentioned this pull request May 23, 2023
Closed
@mickaelistria
Copy link
Contributor Author

See microsoft/vscode-js-debug#926 (comment) about getting dapDebugAdapter conveniently.

@mickaelistria mickaelistria changed the title [WIP] vscode-js-debug Use vscode-js-debug in place of deprecated node-debug2 Oct 2, 2023
@mickaelistria mickaelistria marked this pull request as ready for review October 2, 2023 07:55
@mickaelistria
Copy link
Contributor Author

IP review submitted: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/10778

@mickaelistria mickaelistria marked this pull request as draft October 2, 2023 10:26
@mickaelistria
Copy link
Contributor Author

Moving back to draft as there are still 2 important limitations:

  • The output is not printed in internal console
  • Run mode doesn't seem to work (debug does)

@zulus
Copy link
Contributor

zulus commented Oct 2, 2023

In theory this also replace deprecated chrome debug adapter (pwa-chrome) and supports edge (pwa-msedge, windows only)

@mickaelistria
Copy link
Contributor Author

Both issues listed are fixed in LSP4E DAP support, but there is another issue that now getThreads() doesn't return (request stuck) when the thread isn't suspended. This does cause multiple issues in LSP4E DAP support. I'm investigating fixing it there.

@mickaelistria mickaelistria force-pushed the vscode-js-debug branch 6 times, most recently from 0cae91b to f4f73c3 Compare October 6, 2023 09:30
@mickaelistria
Copy link
Contributor Author

At the moment, I didn't manage to get a TypeScript program being debugged...

@mickaelistria
Copy link
Contributor Author

Submitted question to microsoft/vscode-js-debug#1838

@mickaelistria
Use vscode-js-debug instead of deprecated node-debug2
91482eb 
This also restore ability to debug running Node processes (eg start with
--inspect).

Requires usage of latest LSP4E support for DAP.

Fixes eclipse-wildwebdeveloper#555
@mickaelistria mickaelistria marked this pull request as ready for review October 8, 2023 21:13
@mickaelistria mickaelistria merged commit b6e8837 into eclipse-wildwebdeveloper:master Oct 8, 2023
3 of 4 checks passed
This was referenced Oct 8, 2023
Closed
Closed
Closed
@wesleybl
Copy link

wesleybl commented Oct 10, 2023 •
edited
Loading

@mickaelistria I installed the latest snapshot and I'm not able to debug js files with this new debug. I created a simple js file, right clicked on the file and selected Debug As -> Node Program. Then I get an error window with the message:

An internal error occurred during: "Launching New_configuration".
java.net.ConnectException: Connection refused

The console prints the message:

Debug server listening at 127.0.0.1:46831

How do I debug?

@mickaelistria
Copy link
Contributor Author

Can you please open a new issue about this and share the content of workspace/.metadata/.log ?

@wesleybl wesleybl mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace node debug adapters with vscode-js-debug adapter
3 participants
@mickaelistria @zulus @wesleybl