Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vscode-languageserver-protocol from 3.17.4-next.3 to 3.17.5 in /org.eclipse.wildwebdeveloper #1350

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 26, 2023

Bumps vscode-languageserver-protocol from 3.17.4-next.3 to 3.17.5.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Sep 26, 2023
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/org.eclipse.wildwebdeveloper/vscode-languageserver-protocol-3.17.5 branch 3 times, most recently from 5c176db to d85e2ef Compare October 24, 2023 14:44
@vrubezhny
Copy link
Contributor

@dependabot rebase

Bumps [vscode-languageserver-protocol](https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/protocol) from 3.17.4-next.3 to 3.17.5.
- [Commits](https://github.com/Microsoft/vscode-languageserver-node/commits/release/types/3.17.5/protocol)

---
updated-dependencies:
- dependency-name: vscode-languageserver-protocol
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/org.eclipse.wildwebdeveloper/vscode-languageserver-protocol-3.17.5 branch from d85e2ef to 88ffc73 Compare October 25, 2023 18:40
@mickaelistria
Copy link
Contributor

@vrubezhny As far as I know the vscode-languageserver-protocol should be fetched transitively, shouldn't it? If so, couldn't we just try to remove it from the package.json ?

@vrubezhny
Copy link
Contributor

@vrubezhny As far as I know the vscode-languageserver-protocol should be fetched transitively, shouldn't it? If so, couldn't we just try to remove it from the package.json ?

Yes, it should., but without having both - vscode-languageserver-protocol and vscode-languageserver-types - in package.json it's almost impossible to de-duplacate these dependencies - so the "too long path" test failure occurs quite frequently.

@zulus has added vscode-languageserver@9.0.1, as far as I understand, trying to force de-duplicating the different versions of vscode-languageserver-protocol and vscode-languageserver-types a couple of LSs depends on and thus adding "too long paths" test failure - but as far as I can see it doesn't help.
We were expecting for the vscode 1.83 update to allow using the latest protocol and types modules (3.17.5), but it didn't happen - we still have a mix of versions coming from vscode LSs.

So, I'd better rolled back the change that adds the vscode-languageserver dependnecy to package.json then removed this one.

@vrubezhny
Copy link
Contributor

vrubezhny commented Oct 30, 2023

@mickaelistria I've created PR #1381 aiming to shorten the used NPM module dependency paths and to force vscode LSs to use the latest language service modules (also helps to dedupe some dependencies) - so, if merged, it removes the vscode-languageserver-protocol dependency and makes this PR not be needed anymore.

@mickaelistria
Copy link
Contributor

OK, perfect. Thank you!

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 30, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/org.eclipse.wildwebdeveloper/vscode-languageserver-protocol-3.17.5 branch October 30, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants