Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References to third-party repositories removed #1491

Conversation

OLibutzki
Copy link
Contributor

No description provided.

@mickaelistria
Copy link
Contributor

We can merge it as soon as build is fine and the output p2 repo is verified (the repo is accessible through Jenkins after build completion)
But at the moment, it looks like the build is failing.

@OLibutzki
Copy link
Contributor Author

But at the moment, it looks like the build is failing.

I can confirm that. Maybe this is caused by the target platform which uses https://download.eclipse.org/releases/latest/. Looks like org.eclipse.mylyn.wikitext_feature.feature.group is not part of the repo anymore.

That issue seems not to be related to this PR.

@mickaelistria
Copy link
Contributor

OK, can you please fix the dependency issue by the way?

@OLibutzki
Copy link
Contributor Author

OLibutzki commented Mar 18, 2024

OK, can you please fix the dependency issue by the way?

The feature seems to be renamed:
org.eclipse.mylyn.wikitext_feature --> org.eclipse.mylyn.wikitext.feature

I don't know what to do with org.eclipse.mylyn.wikitext.editors_feature which is used in epp.product. It seems not to exist anymore.

The feature has been removed here: eclipse-mylyn/org.eclipse.mylyn@c44317a

@OLibutzki
Copy link
Contributor Author

I don't know what to do with org.eclipse.mylyn.wikitext.editors_feature which is used in epp.product. It seems not to exist anymore.

I fixed it by using org.eclipse.mylyn.wikitext.feature.

@OLibutzki
Copy link
Contributor Author

Build is successful, but the p2 repo is huge as all the features/plugins of the previously referenced repositories are packaged in it: https://ci.eclipse.org/wildwebdeveloper/job/Wildwebdeveloper/job/PR-1491/lastSuccessfulBuild/artifact/repository/target/repository/

@mickaelistria
Copy link
Contributor

Let's just merge it if it fixes many problems.
I think we should just consider removing the product. This was a replacement for the former "Eclipse IDE for Web and JavaScript developers" package in EPP, but realistically, I don't think it's useful to anyone and I'm certain Victor or myself at least wouldn't mind dropping it.

@mickaelistria mickaelistria merged commit a63a9d5 into eclipse-wildwebdeveloper:master Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants