-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @vue/language-server to 2.0.19, use @vue/typescript-plugin #1520
Conversation
So is this one "blocked" ? |
@zulus Do you think you'll find time to finish this one? |
Can be merged after license clear, editor haven't valid syntax highlighting, but this is tm4e bug |
/request-license-review |
✔️ All licenses already successfully vetted. Workflow run (with attached summary files): |
Please remove the do not merge part and push yourself when ready. |
Licensecheck succeeded now but there are a bunch of extra failures that do not fail on master . |
I forgot commit plugin re-enable, checking in progress |
xD, looks like latest typescript follows LSP protocol, and produce diagnostics only if client inform about publicDiagnostics capability, LSP4E never send this information ;) another blocker... |
|
It seems like the issue are the same one as in #1459 , which seems to be a blocker then. |
@zulus Thanks for figuring this one and fixing lsp4e! |
I strongly support that, you've manage to unblock a long standing chain of actions here; thank you! |
Fortunately I have a lot of time now ;) |
Due vuejs/language-tools#4246 I had to disable typescript-plugin-css-modules and typescript-lit-html-plugin