Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @vue/language-server to 2.0.19, use @vue/typescript-plugin #1520

Merged
merged 1 commit into from
May 22, 2024

Conversation

zulus
Copy link
Contributor

@zulus zulus commented Apr 10, 2024

  • Update @VUE components
  • Remove second vue LS instance
  • Implement TypeScriptPlugin languages section
  • Bind *.vue files to typescript lsp

Due vuejs/language-tools#4246 I had to disable typescript-plugin-css-modules and typescript-lit-html-plugin

@akurtakov
Copy link
Contributor

So is this one "blocked" ?

@akurtakov
Copy link
Contributor

@zulus Do you think you'll find time to finish this one?

@zulus
Copy link
Contributor Author

zulus commented May 21, 2024

Can be merged after license clear, editor haven't valid syntax highlighting, but this is tm4e bug

@akurtakov
Copy link
Contributor

/request-license-review

Copy link

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse-wildwebdeveloper/wildwebdeveloper/actions/runs/9176947316

@akurtakov
Copy link
Contributor

Please remove the do not merge part and push yourself when ready.

@akurtakov
Copy link
Contributor

Licensecheck succeeded now but there are a bunch of extra failures that do not fail on master .

@zulus
Copy link
Contributor Author

zulus commented May 21, 2024

Licensecheck succeeded now but there are a bunch of extra failures that do not fail on master .

I forgot commit plugin re-enable, checking in progress

@zulus zulus changed the title [DO NOT MERGE] Update @vue/language-server to 2.0.11, use @vue/typescript-plugin Update @vue/language-server to 2.0.19, use @vue/typescript-plugin May 21, 2024
@zulus
Copy link
Contributor Author

zulus commented May 21, 2024

Licensecheck succeeded now but there are a bunch of extra failures that do not fail on master .

xD, looks like latest typescript follows LSP protocol, and produce diagnostics only if client inform about publicDiagnostics capability, LSP4E never send this information ;) another blocker...

@zulus
Copy link
Contributor Author

zulus commented May 21, 2024

Licensecheck succeeded now but there are a bunch of extra failures that do not fail on master .

xD, looks like latest typescript follows LSP protocol, and produce diagnostics only if client inform about publicDiagnostics capability, LSP4E never send this information ;) another blocker...

eclipse-lsp4e/lsp4e#1007

@mickaelistria
Copy link
Contributor

It seems like the issue are the same one as in #1459 , which seems to be a blocker then.

@akurtakov
Copy link
Contributor

@zulus Thanks for figuring this one and fixing lsp4e!

@akurtakov akurtakov merged commit 5ec1965 into eclipse-wildwebdeveloper:master May 22, 2024
6 checks passed
@mickaelistria
Copy link
Contributor

Thanks for figuring this one and fixing lsp4e!

I strongly support that, you've manage to unblock a long standing chain of actions here; thank you!

@zulus
Copy link
Contributor Author

zulus commented May 22, 2024

Fortunately I have a lot of time now ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants