support internal/unstable close builder API #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yellowhatter
added
enhancement
milyin
requested changes
Nov 27, 2024
include/zenoh_commons.h
Outdated
| /** | ||
| * The timeout for close operation in milliseconds. 0 means default close timeout which is 10 seconds. | ||
| */ | ||
| uint32_t timeout_ms; |
There was a problem hiding this comment.
I'm wondering how to separate fields of options structures to "core" api and "zenoh-c" (or zenoh-pico) specific API.
It seems that if the structure contains zenoh-c specific fields, it should be zc_close_options_t itself.
This means that we have to add also the function zc_close which takes zc_close_options_t instead of common z_close_options_t.
There was a problem hiding this comment.
Well, z_close is not zenoh-c specific API, as well as option's fields like timeout and out_concurrent - they are present in Rust with some language-specific difference.
Otherwise following your logic, we should zc_* everything that has options API.....
Conflicts: Cargo.lock build-resources/opaque-types/Cargo.lock build-resources/opaque-types/Cargo.toml include/zenoh_macros.h
- close API is unstable and internal
milyin
approved these changes
Dec 4, 2024
milyin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[closes #832 ]
This is temporary API, it's going to be replaced when eclipse-zenoh/zenoh#1626 is implemented