Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ReadTheDocs clang dependency #237

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

evshary
Copy link
Contributor

@evshary evshary commented Aug 4, 2023

It seems like ReadTheDocs uses Ubuntu-22.04 instead Ubuntu-18.04 now.
The clang should also be updated.
I generated my own ReadTheDocs to see whether it makes any difference.

Original one: https://zenoh-pico.readthedocs.io/en/0.7.2-rc/index.html
After update: https://evshary-zenoh-pico.readthedocs.io/en/latest/index.html

There are some display differences on the web page.
@Mallets Could you please check whether this is acceptable or not?

Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@cguimaraes cguimaraes self-requested a review August 4, 2023 11:06
Copy link
Member

@cguimaraes cguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Were you able to test it in a private repo?

@evshary
Copy link
Contributor Author

evshary commented Aug 4, 2023

@cguimaraes Thank you!
I'm not sure whether ReadTheDocs accepts the private repo or not. I need to check.
Anyway, the test page is only for you to check the differences, so I'll delete it after the PR is merged to avoid confusion among users.

@Mallets Mallets merged commit b68364f into eclipse-zenoh:master Aug 4, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants