add -l option to examples #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mallets
requested changes
Sep 13, 2023
examples/unix/c11/z_get.c
Outdated
| @@ -53,11 +53,15 @@ int main(int argc, char **argv) { | |||
| case 'm': | |||
| mode = optarg; | |||
| break; | |||
| case 'l': | |||
| locator = optarg; | |||
| mode = "peer"; | |||
There was a problem hiding this comment.
In addition to that, configuration should be updated accordingly. I.e.: in case of -e the config is:
zp_config_insert(z_loan(config), Z_CONFIG_CONNECT_KEY, z_string_make(locator));
In case of -l the config should be:
zp_config_insert(z_loan(config), Z_CONFIG_LISTEN_KEY, z_string_make(locator));
This comment applies also to all the other examples.
There was a problem hiding this comment.
It seems to me that using Z_CONFIG_LISTEN_KEY would imply more changes. At least from a quick search it is not used anywhere in the code.
Mallets
approved these changes
Sep 15, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.