Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query/reply attachment #403

Merged
merged 20 commits into from
Apr 29, 2024

Conversation

jean-roland
Copy link
Contributor

@jean-roland jean-roland commented Apr 16, 2024

This PR adds attachments to queries and replies + example.

It also fixes an attachment-related memory leak.

Closes #335

.github/workflows/build-check.yaml Show resolved Hide resolved
examples/unix/c11/z_get.c Outdated Show resolved Hide resolved
examples/unix/c11/z_queryable.c Outdated Show resolved Hide resolved
examples/unix/c11/z_queryable.c Outdated Show resolved Hide resolved
examples/unix/c11/z_queryable.c Show resolved Hide resolved
src/protocol/core.c Outdated Show resolved Hide resolved
tests/modularity.py Outdated Show resolved Hide resolved
Copy link
Member

@sashacmc sashacmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mallets Mallets merged commit 2a767bc into eclipse-zenoh:protocol_changes Apr 29, 2024
51 checks passed
@jean-roland jean-roland deleted the ft_attachment branch May 15, 2024 07:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants