Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch reliability from subscriber to publisher. #630

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

jean-roland
Copy link
Contributor

Closes #614.

  • Reliability is now a property of publisher and put/delete instead of subscriber
  • You can retrieve in a sample the reliability it was received with.

Copy link

github-actions bot commented Sep 6, 2024

PR missing one of the required labels: {'documentation', 'bug', 'breaking-change', 'dependencies', 'new feature', 'enhancement', 'internal'}

@jean-roland jean-roland added the enhancement Things could work better label Sep 6, 2024
Copy link
Member

@sashacmc sashacmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jean-roland jean-roland changed the title Switch reliability from publisher to subscriber. Switch reliability from subscriber to publisher. Sep 6, 2024
@@ -218,6 +212,7 @@ typedef struct {
z_congestion_control_t congestion_control;
z_priority_t priority;
_Bool is_express;
z_reliability_t reliability;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reliability is not under Z_FEATURE_UNSTABLE_API anymore ?

@milyin milyin merged commit 9e926b5 into eclipse-zenoh:main Sep 9, 2024
53 checks passed
@jean-roland jean-roland deleted the ft_reliability branch September 10, 2024 14:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move reliability parameter from subscriber to publisher
3 participants