Replace _Bool with bool to make c++ compiler happy #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'breaking-change', 'new feature', 'dependencies', 'bug', 'documentation', 'internal', 'enhancement'} |
DenisBiryukov91
force-pushed
the
fix-bool
branch
from
b525f9f
to
7c9e30b
Compare
DenisBiryukov91
changed the title
DenisBiryukov91
changed the title
|
Superseded by #679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bool is available since C99.
This still does not address the issue of potentially different representation of bool in C vs C++
Also replaces asm argument name which is a reserved keyword in asm windows stub.