Improve throughput performance #3 (rx buffer focus) #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-roland
changed the title
|
PR missing one of the required labels: {'internal', 'new feature', 'bug', 'enhancement', 'dependencies', 'breaking-change', 'documentation'} |
sashacmc
reviewed
Oct 18, 2024
sashacmc
approved these changes
Oct 18, 2024
jean-roland
added a commit
to jean-roland/zenoh-pico
that referenced
this pull request
Nov 13, 2024
…ipse-zenoh#749) * feat: add refcount to z_buf * feat: wrap payload instead of copy * fix: segfaults on tests and examples * feat: pass arg by reference in reply_create * feat: add zbuf copy bytes * fix: zbuf clear memory leak * feat: improve read task buffer realloc logic * doc: update read task comment * feat: add raweth read task buffer allocation * feat: move rx buffer logic to function * fix: zbuf init code * feat: add rc count function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve rx performance we need to reduce the amount of copies that are made. By using a refcount and by allocating dynamically the rx buffers we can avoid copies at the cost of memory allocation, only in the case where data is processed out of context [note: that is the case of query replies in latest consolidation mode].