Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build shared lib for packages instead of static one #757

Merged

Conversation

DenisBiryukov91
Copy link
Contributor

build shared lib for packages instead of static one
Closes #756.

Copy link

PR missing one of the required labels: {'enhancement', 'documentation', 'internal', 'new feature', 'breaking-change', 'bug', 'dependencies'}

@DenisBiryukov91 DenisBiryukov91 marked this pull request as draft October 22, 2024 12:28
@DenisBiryukov91 DenisBiryukov91 added the bug Something isn't working label Oct 22, 2024
@DenisBiryukov91 DenisBiryukov91 marked this pull request as ready for review October 22, 2024 12:38
@milyin milyin merged commit 8aa53e2 into eclipse-zenoh:main Oct 22, 2024
157 of 161 checks passed
gabrik pushed a commit that referenced this pull request Nov 14, 2024
* Update closure handlers documentaion (#736)

* Rename closure callback/dropper types (#739)

* Remove legacy z_zint_t from public API (#741)

* Add `export "C"` for all header files (#740)

* Add `export "C"` for proper closures callbacks export

* Add `export "C"` for all headers

* add serialize from substr functions (#742)

* Rename z_loaned_hello_handler_t to z_closure_hello_callback_t (#743)

* Mark z_reply_replier_id as unstable (#745)

* Add documentation about logging (#744)

* Update README.md (#746)

* hardcode clang-format runner to Ubuntu24.04 (#748)

* fix build granularity (#747)

* fix: badly named constant (#750)

* fix packages

* fix: update debian packaging

- include libzenohpico.so in debian package
- change the package name to libzenohpico in line with libzenohc
- set correct debian version for pre releases
- fix wrong version used in Release mode

* fix: debian dev package name

* fix: package version for releases (#753)

* fix: debian_version for official releases

otherwise they would be undefined

* fix: align cpack version with zenoh-c

* chore: review comments

move cpack version closer to where it's used

* build shared lib for packages instead of static one (#757)

* Fix z_task cleanup for platforms with pthread support (#759)

* Fix read/lease task cleanup (#760)

* Align ID string representation with zenoh (lowercase) (#761)

* Remove default parameters from z_closure (#755)

* build both libraries:shared and static when packaging; (#766)

add static library to dev package;

* Publish debian packages (#769)

* fix: add workflow to release debian packages

* fix: align with zenoh-c

- update package names
- set version string in the same way
- set DEBARCH/RPMARCH
- set CPACK_PACKAGE_FILE_NAME
- add -j to zip archive to not include parent folder

* fix: use CPACK_PACKAGE_NAME

* fix: pass package name to all build targets

* fix: Don't tag release branch during dry-run

* Replace exit with return in zephyr examples (#774)

* Add platform_common.c to zephyr CMakeLists.txt file

* Rework Zenoh ID conversion

* chore: Update org secrets (#782)

As per eclipse-zenoh/.eclipsefdn#18, secrets were updated to follow eclipse foundation naming convention.

* fix: rebase shenanigans

* feat: set batching api as unstable

---------

Co-authored-by: Alexander Bushnev <Alexander@Bushnev.pro>
Co-authored-by: DenisBiryukov91 <155981813+DenisBiryukov91@users.noreply.github.com>
Co-authored-by: Denis Biryukov <denis.biryukov@zettascale.tech>
Co-authored-by: Diogo Mendes Matsubara <diogo.matsubara@zettascale.tech>
Co-authored-by: Luca Cominardi <luca.cominardi@gmail.com>
gabrik pushed a commit that referenced this pull request Nov 18, 2024
* Update closure handlers documentaion (#736)

* Rename closure callback/dropper types (#739)

* Remove legacy z_zint_t from public API (#741)

* Add `export "C"` for all header files (#740)

* Add `export "C"` for proper closures callbacks export

* Add `export "C"` for all headers

* add serialize from substr functions (#742)

* Rename z_loaned_hello_handler_t to z_closure_hello_callback_t (#743)

* Mark z_reply_replier_id as unstable (#745)

* Add documentation about logging (#744)

* Update README.md (#746)

* hardcode clang-format runner to Ubuntu24.04 (#748)

* fix build granularity (#747)

* fix: badly named constant (#750)

* fix packages

* fix: update debian packaging

- include libzenohpico.so in debian package
- change the package name to libzenohpico in line with libzenohc
- set correct debian version for pre releases
- fix wrong version used in Release mode

* fix: debian dev package name

* fix: package version for releases (#753)

* fix: debian_version for official releases

otherwise they would be undefined

* fix: align cpack version with zenoh-c

* chore: review comments

move cpack version closer to where it's used

* build shared lib for packages instead of static one (#757)

* Fix z_task cleanup for platforms with pthread support (#759)

* Fix read/lease task cleanup (#760)

* Align ID string representation with zenoh (lowercase) (#761)

* Remove default parameters from z_closure (#755)

* build both libraries:shared and static when packaging; (#766)

add static library to dev package;

* Publish debian packages (#769)

* fix: add workflow to release debian packages

* fix: align with zenoh-c

- update package names
- set version string in the same way
- set DEBARCH/RPMARCH
- set CPACK_PACKAGE_FILE_NAME
- add -j to zip archive to not include parent folder

* fix: use CPACK_PACKAGE_NAME

* fix: pass package name to all build targets

* fix: Don't tag release branch during dry-run

* Replace exit with return in zephyr examples (#774)

* Add platform_common.c to zephyr CMakeLists.txt file

* Rework Zenoh ID conversion

* chore: Update org secrets (#782)

As per eclipse-zenoh/.eclipsefdn#18, secrets were updated to follow eclipse foundation naming convention.

* Implement liveliness support (#632)

* fix: merge shenanigans

* fix: integration test issues

* fix: missing send reply final

* fix: liveliness double free

---------

Co-authored-by: Alexander Bushnev <Alexander@Bushnev.pro>
Co-authored-by: DenisBiryukov91 <155981813+DenisBiryukov91@users.noreply.github.com>
Co-authored-by: Denis Biryukov <denis.biryukov@zettascale.tech>
Co-authored-by: Diogo Mendes Matsubara <diogo.matsubara@zettascale.tech>
Co-authored-by: Luca Cominardi <luca.cominardi@gmail.com>
gabrik pushed a commit that referenced this pull request Nov 19, 2024
* Update closure handlers documentaion (#736)

* Rename closure callback/dropper types (#739)

* Remove legacy z_zint_t from public API (#741)

* Add `export "C"` for all header files (#740)

* Add `export "C"` for proper closures callbacks export

* Add `export "C"` for all headers

* add serialize from substr functions (#742)

* Rename z_loaned_hello_handler_t to z_closure_hello_callback_t (#743)

* Mark z_reply_replier_id as unstable (#745)

* Add documentation about logging (#744)

* Update README.md (#746)

* hardcode clang-format runner to Ubuntu24.04 (#748)

* fix build granularity (#747)

* fix: badly named constant (#750)

* fix packages

* fix: update debian packaging

- include libzenohpico.so in debian package
- change the package name to libzenohpico in line with libzenohc
- set correct debian version for pre releases
- fix wrong version used in Release mode

* fix: debian dev package name

* fix: package version for releases (#753)

* fix: debian_version for official releases

otherwise they would be undefined

* fix: align cpack version with zenoh-c

* chore: review comments

move cpack version closer to where it's used

* build shared lib for packages instead of static one (#757)

* Fix z_task cleanup for platforms with pthread support (#759)

* Fix read/lease task cleanup (#760)

* Align ID string representation with zenoh (lowercase) (#761)

* Remove default parameters from z_closure (#755)

* build both libraries:shared and static when packaging; (#766)

add static library to dev package;

* Publish debian packages (#769)

* fix: add workflow to release debian packages

* fix: align with zenoh-c

- update package names
- set version string in the same way
- set DEBARCH/RPMARCH
- set CPACK_PACKAGE_FILE_NAME
- add -j to zip archive to not include parent folder

* fix: use CPACK_PACKAGE_NAME

* fix: pass package name to all build targets

* fix: Don't tag release branch during dry-run

* Replace exit with return in zephyr examples (#774)

* Add platform_common.c to zephyr CMakeLists.txt file

* Rework Zenoh ID conversion

* chore: Update org secrets (#782)

As per eclipse-zenoh/.eclipsefdn#18, secrets were updated to follow eclipse foundation naming convention.

* Implement liveliness support (#632)

* Mark liveliness API as unstable and disable by default

* Fix typo (#787)

* fix: correct 1.1 issues

* feat: add zp_batch_flush

* fix: switch to #if 0 to deactivate tcp function

---------

Co-authored-by: Alexander Bushnev <Alexander@Bushnev.pro>
Co-authored-by: DenisBiryukov91 <155981813+DenisBiryukov91@users.noreply.github.com>
Co-authored-by: Denis Biryukov <denis.biryukov@zettascale.tech>
Co-authored-by: Diogo Mendes Matsubara <diogo.matsubara@zettascale.tech>
Co-authored-by: Luca Cominardi <luca.cominardi@gmail.com>
gabrik pushed a commit that referenced this pull request Nov 20, 2024
* Update closure handlers documentaion (#736)

* Rename closure callback/dropper types (#739)

* Remove legacy z_zint_t from public API (#741)

* Add `export "C"` for all header files (#740)

* Add `export "C"` for proper closures callbacks export

* Add `export "C"` for all headers

* add serialize from substr functions (#742)

* Rename z_loaned_hello_handler_t to z_closure_hello_callback_t (#743)

* Mark z_reply_replier_id as unstable (#745)

* Add documentation about logging (#744)

* Update README.md (#746)

* hardcode clang-format runner to Ubuntu24.04 (#748)

* fix build granularity (#747)

* fix: badly named constant (#750)

* fix packages

* fix: update debian packaging

- include libzenohpico.so in debian package
- change the package name to libzenohpico in line with libzenohc
- set correct debian version for pre releases
- fix wrong version used in Release mode

* fix: debian dev package name

* fix: package version for releases (#753)

* fix: debian_version for official releases

otherwise they would be undefined

* fix: align cpack version with zenoh-c

* chore: review comments

move cpack version closer to where it's used

* build shared lib for packages instead of static one (#757)

* Fix z_task cleanup for platforms with pthread support (#759)

* Fix read/lease task cleanup (#760)

* Align ID string representation with zenoh (lowercase) (#761)

* Remove default parameters from z_closure (#755)

* build both libraries:shared and static when packaging; (#766)

add static library to dev package;

* Publish debian packages (#769)

* fix: add workflow to release debian packages

* fix: align with zenoh-c

- update package names
- set version string in the same way
- set DEBARCH/RPMARCH
- set CPACK_PACKAGE_FILE_NAME
- add -j to zip archive to not include parent folder

* fix: use CPACK_PACKAGE_NAME

* fix: pass package name to all build targets

* fix: Don't tag release branch during dry-run

* Replace exit with return in zephyr examples (#774)

* Add platform_common.c to zephyr CMakeLists.txt file

* Rework Zenoh ID conversion

* chore: Update org secrets (#782)

As per eclipse-zenoh/.eclipsefdn#18, secrets were updated to follow eclipse foundation naming convention.

* Implement liveliness support (#632)

* Mark liveliness API as unstable and disable by default

* Fix typo (#787)

* fix: prevent code duplication during merge

---------

Co-authored-by: Alexander Bushnev <Alexander@Bushnev.pro>
Co-authored-by: DenisBiryukov91 <155981813+DenisBiryukov91@users.noreply.github.com>
Co-authored-by: Denis Biryukov <denis.biryukov@zettascale.tech>
Co-authored-by: Diogo Mendes Matsubara <diogo.matsubara@zettascale.tech>
Co-authored-by: Luca Cominardi <luca.cominardi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] libzenohpico package released with static library
2 participants