Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic Whitelisting/Blacklisting #16

Closed
kydos opened this issue Nov 6, 2020 · 2 comments
Closed

Topic Whitelisting/Blacklisting #16

kydos opened this issue Nov 6, 2020 · 2 comments
Assignees
@kydos
Labels
enhancement New feature or request

Comments

@kydos
Copy link
Member

kydos commented Nov 6, 2020

It would be useful to be able to control by configuration the DDS topics that should not be exposed via zenoh resources or viceversa the set of those that should be.
@kydos kydos added the enhancement New feature or request label Nov 6, 2020
@kydos kydos self-assigned this Nov 6, 2020
kydos added a commit that referenced this issue Mar 16, 2021
@kydos
Made DDS domain configurable by command line arg (#27) and introduce …
c7dee97 
…the specification of an allow regular expression (#16)
kydos added a commit that referenced this issue Mar 16, 2021
@kydos
Made DDS domain configurable by command line arg (#27) and introduce …
cc36d42 
…the specification of an allow regular expression (#16)
@JEnoch
Copy link
Member

JEnoch commented Sep 22, 2021

Whiltelisting is implemented via the --allow option.
However blacklisting is not, since the regular expression accepted by this option doesn't support negative matching. The cause being the regex crate that we use (see rust-lang/regex#127).

This was referenced Jan 17, 2022
Closed
Merged
@JEnoch
Copy link
Member

JEnoch commented Jan 19, 2022

PR #68 adds the deny configuration (via config file) and the --deny command line option.
If both allow and deny are set a partition and/or topic will be allowed if it matches only the allow expression.

@JEnoch JEnoch closed this as completed Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kydos kydos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kydos @JEnoch