Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Bridge plugin sources #1

Merged
merged 21 commits into from
Apr 24, 2023
Merged

WIP: Bridge plugin sources #1

merged 21 commits into from
Apr 24, 2023

Conversation

yellowhatter
Copy link
Contributor

No description provided.

Mallets
Mallets reviewed Apr 13, 2023
View reviewed changes
zplugin-ros1/Cargo.toml Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Apr 13, 2023
View reviewed changes
zplugin-ros1/Cargo.toml Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Apr 13, 2023
View reviewed changes
zplugin-ros1/Cargo.toml Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Apr 13, 2023
View reviewed changes
zplugin-ros1/Cargo.toml Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Apr 13, 2023
View reviewed changes
zplugin-ros1/Cargo.toml Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Apr 13, 2023
View reviewed changes
zplugin-ros1/Cargo.toml Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Apr 13, 2023
View reviewed changes
zplugin-ros1/Cargo.toml Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Apr 13, 2023
View reviewed changes
zplugin-ros1/src/lib.rs Outdated Show resolved Hide resolved
@Mallets
Copy link
Member

Mallets commented Apr 13, 2023 •
edited
Loading

Please run cargo clippy --all-targets to get the full set of warnings.
Also run cargo fmt --all to format the code.

Mallets
Mallets reviewed Apr 13, 2023
View reviewed changes
zplugin-ros1/src/lib.rs Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Apr 13, 2023
View reviewed changes
zplugin-ros1/src/lib.rs Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Apr 14, 2023
View reviewed changes
zplugin-ros1/src/lib.rs Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Apr 20, 2023
View reviewed changes
zenoh-dragon.png Outdated Show resolved Hide resolved
@yellowhatter
Some improvements to tests
d588c14
@yellowhatter
- some brush-up
59dd7cc 
- remove old logo file
- move common test code to test_helpers.rs
- remove unnecessary topic_name and datatype restrictions
@yellowhatter
Update README.md
1489785
@yellowhatter yellowhatter marked this pull request as ready for review April 24, 2023 15:07
@Mallets Mallets merged commit 46dd1fa into eclipse-zenoh:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yellowhatter @Mallets