Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't close multicast transport on OS error 55 #1548

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Don't close multicast transport on OS error 55 #1548

merged 3 commits into from
Oct 18, 2024

Conversation

OlivierHecart
Copy link
Contributor

When sending high throughput through multicast transport the following could occur:

TX task failed: Write error on UDP link 192.168.0.1:51381 => 224.0.0.1:17511: No buffer space available (os error 55) at io/zenoh-links/zenoh-link-udp/src/multicast.rs:88.
Closing multicast transport on udp/224.0.0.1:17511

Now Zenoh logs and ignores the error.

@OlivierHecart OlivierHecart added the bug Something isn't working label Oct 18, 2024
Mallets
Mallets requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@Mallets Mallets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it LGTM. Please see my comment on platform-specific codes.

io/zenoh-links/zenoh-link-udp/src/multicast.rs Show resolved Hide resolved
@Mallets Mallets merged commit 1877831 into main Oct 18, 2024
24 checks passed
@Mallets Mallets deleted the bug/multicast_os_error branch October 18, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OlivierHecart @Mallets