Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document callback drop on subscriber undeclaration #1590

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fuzzypixelz
Copy link
Member

No description provided.

@fuzzypixelz fuzzypixelz added the documentation Improvements or additions to documentation label Nov 12, 2024
@wyfo
Copy link
Contributor

wyfo commented Nov 12, 2024

If I'm not mistaken, the callback is not dropped during the undeclaration, and that is an issue regarding C/C++ users' point of view and "unsafe" use.
In fact, some read task may have cloned the callback before the undeclaration, and therefore use it after. We would like to "improve" this behavior and wait the last callback to be dropped, notably to match C/C++ users' expectations, but for now, I will not touch the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation not sure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants